Rework TranscriptionManager#860
Closed
peter-olai wants to merge 4 commits intoNPC-Prefab-Improvementsfrom
Closed
Conversation
Updated multiple Unity scenes and scripts to integrate server-side transcription capabilities. Key changes include the addition of `ServerTranscriptionManager` for managing audio transcription through a server API, modifications to `MicrophoneDemo.cs` for improved audio recording, and enhancements to UI elements for user interaction. Also updated occlusion culling and render settings in `MyTry.unity`, along with adjustments to prefab properties across various assets. refs: #1
- Modified `_nPCs` array size in `ReceptionOutdoor.unity`. - Removed `transcriptionApiUrl` and updated metadata in prefab. - Enhanced `Electronic Highway Sign SDF.asset` with new glyph metrics. - Changed API endpoint to local server in `AIRequest.cs`. - Simplified query handling in `AIConversationController.cs`. - Disabled server transcription in `TranscriptionManager.prefab`. refs: #1
HaluBoi
requested changes
May 2, 2025
HaluBoi
left a comment
HaluBoi
left a comment
There was a problem hiding this comment.
There's a problem with finding the microphone when running the application on the Quest, so let's fix that before merging these changes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduces transcription on the server side, which is handled by sending sound files to an external server ran in chat-service
What is the current behavior? (You can also link to an open issue here)
Transcription only on client side
What is the new behavior? (if this is a feature change)
Transcription can be sent to a backend to minimize transcription time. Local transcription is also more optimized.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
You need to be sure that you set the server-IP on the TranscriptionManager manually if you change where the server is ran. The option to change this post build is not yet implemented and is scrapped due to time constraints.
Other information:
MAKE SURE TO SET TRANSCRIPTIONMANAGER SETTINGS TO YOUR NEEDS.
If unticked it will transcribe locally, and via the Transcription Api Url otherwise
There is an import which is located in Assets>Samples>6 - MyTry
This needs to be reworked to be a prettier package when exporting this project later on.